Issue 6641049: code review 6641049: cmd/ld: use 64-bit alignment for large data and bss objects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6641049: code review 6641049: cmd/ld: use 64-bit alignment for large data and bss objects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by rsc

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, iant, dvyukov

Visibility:
Public.

Description

cmd/ld: use 64-bit alignment for large data and bss objects Check for specific, important misalignment in garbage collector. Not a complete fix for issue 599 but an important workaround. Update issue 599.

Patch Set 1 #

Patch Set 2 : diff -r 2c2052f38c3c https://code.google.com/p/go #

Patch Set 3 : diff -r 2c2052f38c3c https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r e35b400683e0 https://code.google.com/p/go #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/cmd/ld/data.c	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 10 months ago (2012-10-09 16:43:23 UTC) #1

dvyukov

https://codereview.appspot.com/6641049/diff/5001/src/cmd/ld/data.c File src/cmd/ld/data.c (right): https://codereview.appspot.com/6641049/diff/5001/src/cmd/ld/data.c#newcode835 src/cmd/ld/data.c:835: s = rnd(s, 8); how it will align struct ...

12 years, 10 months ago (2012-10-09 16:48:04 UTC) #3

rsc

12 years, 10 months ago (2012-10-09 16:49:21 UTC) #4

rsc

12 years, 10 months ago (2012-10-09 16:50:13 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=b9906e2737fa ***

cmd/ld: use 64-bit alignment for large data and bss objects

Check for specific, important misalignment in garbage collector.
Not a complete fix for issue 599 but an important workaround.

Update issue 599.

R=golang-dev, iant, dvyukov
CC=golang-dev
http://codereview.appspot.com/6641049

Expand All Messages | Collapse All Messages