Issue 6625071: code review 6625071: runtime: FreeBSD/ARM support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6625071: code review 6625071: runtime: FreeBSD/ARM support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by minux1

Modified:
12 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: FreeBSD/ARM support

Patch Set 1 #

Patch Set 2 : diff -r 3787ef7b4700 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3787ef7b4700 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3787ef7b4700 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 06308c9edb43 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 06308c9edb43 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 18dffd0c07b2 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 189cd011c4f3 https://code.google.com/p/go/ #

Patch Set 9 : diff -r 189cd011c4f3 https://code.google.com/p/go/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+609 lines, -0 lines)			Patch
A	src/pkg/runtime/defs_freebsd_arm.h	View	1	1 chunk	+183 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/rt0_freebsd_arm.s	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/signal_freebsd_arm.c	View	1 2 3	1 chunk	+156 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/sys_freebsd_arm.s	View	1 2 3 4 5	1 chunk	+262 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 10 months ago (2012-10-11 20:09:20 UTC) #1

minux1

On 2012/10/12 15:14:19, rsc wrote: > LGTM Thank you very much.

12 years, 10 months ago (2012-10-12 15:15:23 UTC) #3

minux1

12 years, 10 months ago (2012-10-12 15:20:00 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=cfa9208b98fc ***

runtime: FreeBSD/ARM support

R=rsc
CC=golang-dev
http://codereview.appspot.com/6625071

Expand All Messages | Collapse All Messages