code review 6622056: cmd/gc: Don't accept qualified names as literal keys

cmd/gc: Don't accept qualified names as literal keys

Fixes issue 4067.

[DMorsing, 2012-10-07 05:27:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[DMorsing, 2012-10-07 05:29:55]

Note that this CL is practically the same as
https://codereview.appspot.com/6532058/ . I couldn't clpatch the old CL back to
my machine because of some conflicts.

[minux1, 2012-10-07 05:39:08]

On Sun, Oct 7, 2012 at 1:29 PM, <daniel.morsing@gmail.com> wrote:

> Note that this CL is practically the same as
>
https://codereview.appspot.**com/6532058/<https://codereview.appspot.com/6532....
I couldn't clpatch the old CL
> back to my machine because of some conflicts.
>
http://code.google.com/p/go/issues/detail?id=3674#c1
contains a good tip for this.

[dave_cheney.net, 2012-10-07 05:42:55]

Nice tip. I've also taken to doing hg import $CODEREVIEW_URL
--no-commit [--force]

On Sun, Oct 7, 2012 at 4:38 PM, minux <minux.ma@gmail.com> wrote:
>
> On Sun, Oct 7, 2012 at 1:29 PM, <daniel.morsing@gmail.com> wrote:
>>
>> Note that this CL is practically the same as
>> https://codereview.appspot.com/6532058/ . I couldn't clpatch the old CL
>> back to my machine because of some conflicts.
>
> http://code.google.com/p/go/issues/detail?id=3674#c1
> contains a good tip for this.

[rsc, 2012-10-07 14:23:45]

LGTM

[DMorsing, 2012-10-07 14:47:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=c122c85d0363 ***

cmd/gc: Don't accept qualified names as literal keys

Fixes issue 4067.

R=golang-dev, minux.ma, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6622056