Issue 6615058: code review 6615058: cmd/gc: more graceful handling of invalid fields in wid...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6615058: code review 6615058: cmd/gc: more graceful handling of invalid fields in wid... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by remyoudompheng

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: more graceful handling of invalid fields in widstruct. The protection against segfaults does not completely solve crashes and breaks test/fixedbugs/bug365.go

Patch Set 1 #

Patch Set 2 : diff -r b5a96da82ce0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5a96da82ce0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b77af9fe6f56 https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/cmd/gc/align.c	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-10-07 17:49:49 UTC) #1

remyoudompheng

12 years, 10 months ago (2012-10-07 19:46:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9a6354dbc50c ***

cmd/gc: more graceful handling of invalid fields in widstruct.

The protection against segfaults does not completely solve
crashes and breaks test/fixedbugs/bug365.go

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6615058

Expand All Messages | Collapse All Messages