code review 6611059: testing: change -test.benchtime to a flag.Duration.

testing: change -test.benchtime to a flag.Duration.

Fixes issue 3902.

[dsymonds, 2012-10-08 10:29:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-10-08 10:35:42]

That's the only match for /flag\..*time/ that isn't already using
flag.Duration. We could do a more extensive audit, though.

[minux1, 2012-10-08 10:36:19]

also need to update:
misc/zsh/go: Line 91
test/fixedbugs/bug369.go: Line 41

[dsymonds, 2012-10-08 10:46:03]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-08 10:46:24]

On Mon, Oct 8, 2012 at 9:35 PM, David Symonds <dsymonds@golang.org> wrote:

> That's the only match for /flag\..*time/ that isn't already using
> flag.Duration. We could do a more extensive audit, though.

I checked all the other flag definitions in the standard packages and
commands. This was the only one.

[minux1, 2012-10-08 10:51:53]

LGTM.

[rsc, 2012-10-08 14:45:02]

LGTM

This will break things but it's the right thing to do.
Also the Go 1 compatibility is about the language, not tools.

Wait for r.

[dsymonds, 2012-10-08 21:15:49]

On Tue, Oct 9, 2012 at 1:45 AM, Russ Cox <rsc@golang.org> wrote:

> This will break things but it's the right thing to do.
> Also the Go 1 compatibility is about the language, not tools.

Is there a doc this should be called out in?

[r, 2012-10-08 21:30:30]

The go1compat document already says, "the Go tool chain (compilers,
linkers, build tools, and so on) are under active development and may
change behavior."

So LGTM

[dsymonds, 2012-10-08 21:57:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=35b8803b82b5 ***

testing: change -test.benchtime to a flag.Duration.

Fixes issue 3902.

R=golang-dev, minux.ma, rsc, r
CC=golang-dev
http://codereview.appspot.com/6611059