Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 6592056: code review 6592056: pkg/runtime: Plan 9, 64-bit: Mask all SSE floating-poin... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by akumar
Modified:
11 years, 5 months ago
Reviewers:
CC:
rsc, rminnich, minux1, golang-dev
Visibility:
Public.

Description

pkg/runtime: Plan 9, 64-bit: Mask all SSE floating-point exceptions The Go run-time assumes that all SSE floating-point exceptions are masked so that Go programs are not broken by such invalid operations. By default, the 64-bit version of the Plan 9 kernel masks only some SSE floating-point exceptions. Here, we mask them all on a per-thread basis.

Patch Set 1 #

Patch Set 2 : diff -r b09f4985724f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b09f4985724f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b09f4985724f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b09f4985724f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/pkg/runtime/os_plan9.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/sys_plan9_386.s View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_plan9_amd64.s View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_plan9.c View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
akumar
Hello rsc@golang.org, rminnich@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-10-02 05:33:00 UTC) #1
akumar
Uploaded the declaration in os_plan9.h as well. Forgot to include that in the first round. ...
11 years, 6 months ago (2012-10-02 05:42:50 UTC) #2
minux1
does 6l automatically link in the math package for this to work?
11 years, 6 months ago (2012-10-02 05:43:40 UTC) #3
akumar
Ah, no, not by default. It doesn't hurt to duplicate this in pkg/runtime anyways. Will ...
11 years, 6 months ago (2012-10-02 06:08:36 UTC) #4
akumar
PTAL. On 2012/10/02 05:43:40, minux wrote: > does 6l automatically link in the math package ...
11 years, 6 months ago (2012-10-02 06:24:42 UTC) #5
rsc
LGTM Please omit pkg/ in CL descriptions. I'll fix this as I submit it.
11 years, 5 months ago (2012-10-05 20:19:14 UTC) #6
rsc
11 years, 5 months ago (2012-10-05 20:30:02 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=23ceb3cf4401 ***

runtime: mask SSE exceptions on plan9/amd64

The Go run-time assumes that all SSE floating-point exceptions
are masked so that Go programs are not broken by such invalid
operations. By default, the 64-bit version of the Plan 9 kernel
masks only some SSE floating-point exceptions. Here, we mask
them all on a per-thread basis.

R=rsc, rminnich, minux.ma
CC=golang-dev
http://codereview.appspot.com/6592056

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b