code review 6587071: builder: set charset utf-8

misc/dashboard: set charset utf-8 on build log downloads

Fixes issue 4187

[bradfitz, 2012-10-03 15:07:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2012-10-03 15:08:24]

That's so crazy it might just work.
On 4 Oct 2012 01:07, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> builder: set charset utf-8
>
> Fixes issue 4187
>
> Please review this at
http://codereview.appspot.com/**6587071/<http://codereview.appspot.com/6587071/>
>
> Affected files:
>   M misc/dashboard/app/build/**handler.go
>
>
> Index: misc/dashboard/app/build/**handler.go
> ==============================**==============================**=======
> --- a/misc/dashboard/app/build/**handler.go
> +++ b/misc/dashboard/app/build/**handler.go
> @@ -322,7 +322,7 @@
>  // logHandler displays log text for a given hash.
>  // It handles paths like "/log/hash".
>  func logHandler(w http.ResponseWriter, r *http.Request) {
> -       w.Header().Set("Content-type", "text/plain")
> +       w.Header().Set("Content-type", "text/plain; charset=utf-8")
>         c := appengine.NewContext(r)
>         hash := r.URL.Path[len("/log/"):]
>         key := datastore.NewKey(c, "Log", hash, 0, nil)
>
>
>

[minux1, 2012-10-03 15:13:50]

LGTM.

the description could better use "misc/dashboard" than builder.

[bradfitz, 2012-10-03 15:18:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=3efc9b624f3e ***

misc/dashboard: set charset utf-8 on build log downloads

Fixes issue 4187

R=golang-dev, dave, minux.ma
CC=golang-dev
http://codereview.appspot.com/6587071