Issue 6584071: code review 6584071: crypto/sha512: 1.28x speedup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6584071: code review 6584071: crypto/sha512: 1.28x speedup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dchest

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

crypto/sha{256,512}: 1.28x speedup SHA-512: benchmark old ns/op new ns/op delta BenchmarkHash1K 14323 11163 -22.06% BenchmarkHash8K 114120 88693 -22.28% benchmark old MB/s new MB/s speedup BenchmarkHash1K 71.49 91.73 1.28x BenchmarkHash8K 71.78 92.36 1.29x SHA-256: benchmark old ns/op new ns/op delta BenchmarkHash1K 21686 16912 -22.01% BenchmarkHash8K 173216 135020 -22.05% benchmark old MB/s new MB/s speedup BenchmarkHash1K 47.22 60.55 1.28x BenchmarkHash8K 47.29 60.67 1.28x

Patch Set 1 #

Patch Set 2 : diff -r 3ae6c87de7f2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3ae6c87de7f2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3ae6c87de7f2 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	src/pkg/crypto/sha256/sha256block.go	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/pkg/crypto/sha512/sha512block.go	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dchest

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-10-03 10:33:38 UTC) #1

rsc

12 years, 11 months ago (2012-10-05 21:04:52 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c6f9c0f01c09 ***

crypto/sha256, crypto/sha512: 1.3x speedup

SHA-256:

benchmark          old ns/op    new ns/op    delta
BenchmarkHash1K        21686        16912  -22.01%
BenchmarkHash8K       173216       135020  -22.05%

benchmark           old MB/s     new MB/s  speedup
BenchmarkHash1K        47.22        60.55    1.28x
BenchmarkHash8K        47.29        60.67    1.28x

SHA-512:

benchmark          old ns/op    new ns/op    delta
BenchmarkHash1K        14323        11163  -22.06%
BenchmarkHash8K       114120        88693  -22.28%

benchmark           old MB/s     new MB/s  speedup
BenchmarkHash1K        71.49        91.73    1.28x
BenchmarkHash8K        71.78        92.36    1.29x

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6584071

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages