code review 6569057: runtime: store types of allocated objects

runtime: store types of allocated objects

[atom, 2012-09-26 14:35:55]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-10-06 22:08:36]

looks good. just a few tiny things

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/iface.c
File src/pkg/runtime/iface.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/iface.c#newcode718
src/pkg/runtime/iface.c:718: if(n == 0) {
Do you want to move this down a few lines and use if(size == 0)? That will
handle the case of 0-length array elements.

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/mgc0.go
File src/pkg/runtime/mgc0.go (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/mgc0.go#newcode10
src/pkg/runtime/mgc0.go:10: *ret = a
*ret = (*m)(nil)

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/proc.c#newcode831
src/pkg/runtime/proc.c:831: static Type *mtype;  // The Go type *M
The Go type M (no star)

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/slice.c
File src/pkg/runtime/slice.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/slice.c#newcode52
src/pkg/runtime/slice.c:52: if(cap == 0)
size == 0 ?

[atom, 2012-10-12 16:00:32]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[atom, 2012-10-12 16:00:40]

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/iface.c
File src/pkg/runtime/iface.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/iface.c#newcode718
src/pkg/runtime/iface.c:718: if(n == 0) {
On 2012/10/06 22:08:36, rsc wrote:
> Do you want to move this down a few lines and use if(size == 0)? That will
> handle the case of 0-length array elements.

Done.

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/mgc0.go
File src/pkg/runtime/mgc0.go (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/mgc0.go#newcode10
src/pkg/runtime/mgc0.go:10: *ret = a
On 2012/10/06 22:08:36, rsc wrote:
> *ret = (*m)(nil)

Done.

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/proc.c#newcode831
src/pkg/runtime/proc.c:831: static Type *mtype;  // The Go type *M
On 2012/10/06 22:08:36, rsc wrote:
> The Go type M (no star)

Done.

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/slice.c
File src/pkg/runtime/slice.c (right):

https://codereview.appspot.com/6569057/diff/1/src/pkg/runtime/slice.c#newcode52
src/pkg/runtime/slice.c:52: if(cap == 0)
On 2012/10/06 22:08:36, rsc wrote:
> size == 0 ?

Done.

[rsc, 2012-10-21 21:33:46]

LGTM

[rsc, 2012-10-21 21:41:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=731e3ce78fcb ***

runtime: store types of allocated objects

R=rsc
CC=golang-dev
http://codereview.appspot.com/6569057

Committer: Russ Cox <rsc@golang.org>