Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1624)

Issue 6559043: code review 6559043: doc: Add important info for would-be go contributors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by feinberg
Modified:
11 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

doc: Add important info for would-be go contributors. Link to the "installing from source" docs instead of the "installing" docs. Remind would-be hacker to switch to the default branch from the release branch.

Patch Set 1 #

Patch Set 2 : diff -r 44b9f2d5eb03 https://code.google.com/p/go #

Patch Set 3 : diff -r e7b37dd77791 https://code.google.com/p/go #

Total comments: 6

Patch Set 4 : diff -r cfbcf8176d26 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M doc/contribute.html View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/install-source.html View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6
feinberg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2012-09-24 18:22:47 UTC) #1
rsc
Thanks for fixing this. http://codereview.appspot.com/6559043/diff/4001/doc/install-source.html File doc/install-source.html (right): http://codereview.appspot.com/6559043/diff/4001/doc/install-source.html#newcode155 doc/install-source.html:155: <p>If you intend to modify ...
11 years, 6 months ago (2012-09-24 18:33:55 UTC) #2
feinberg
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-25 13:53:04 UTC) #3
feinberg
https://codereview.appspot.com/6559043/diff/4001/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/6559043/diff/4001/doc/install-source.html#newcode155 doc/install-source.html:155: <p>If you intend to modify the go source code, ...
11 years, 6 months ago (2012-09-25 13:53:59 UTC) #4
rsc
LGTM
11 years, 6 months ago (2012-09-26 18:39:06 UTC) #5
rsc
11 years, 6 months ago (2012-09-26 18:39:36 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=9bcb9d4f9924 ***

doc: add important info for would-be go contributors.

Link to the "installing from source" docs instead of the "installing" docs.

Remind would-be hacker to switch to the default branch from the release branch.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6559043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b