Issue 6558047: code review 6558047: acme: mouse movement for Del

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6558047: code review 6558047: acme: mouse movement for Del (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:

CC:
r

Visibility:
Public.

Description

acme: mouse movement for Del If the mouse was in the tag of the old window, it was most likely pointing at Del. If bringing up a new window from below and not moving the mouse somewhere else, adjust it so that it ends up pointing at Del in the replacement window's tag too. This makes it easy to Del a sequence of windows in a column, from top to bottom. http://www.youtube.com/watch?v=ET8w6RT6u5M

Patch Set 1 #

Patch Set 2 : diff -r 62ee5c96a66a ssh://hg@bitbucket.org/rsc/plan9port #

Patch Set 3 : diff -r 44552dbb04d6 https://code.google.com/p/plan9port #

Patch Set 4 : diff -r 44552dbb04d6 https://code.google.com/p/plan9port #

Patch Set 5 : diff -r a891d615d12d https://code.google.com/p/plan9port #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -8 lines)			Patch
M	src/cmd/acme/cols.c	View	1	4 chunks	+11 lines, -4 lines	0 comments	Download
M	src/cmd/acme/dat.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/acme/fns.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/acme/util.c	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/cmd/acme/wind.c	View	1	2 chunks	+40 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r, I'd like you to review this change to https://code.google.com/p/plan9port

12 years, 3 months ago (2012-09-24 01:16:42 UTC) #1

rsc

12 years, 3 months ago (2012-09-24 02:01:59 UTC) #3

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=0651cc070604
***

acme: mouse movement for Del

If the mouse was in the tag of the old window,
it was most likely pointing at Del. If bringing up a
new window from below and not moving the mouse
somewhere else, adjust it so that it ends up pointing
at Del in the replacement window's tag too.
This makes it easy to Del a sequence of windows in
a column, from top to bottom.

http://www.youtube.com/watch?v=ET8w6RT6u5M

R=r
http://codereview.appspot.com/6558047

Expand All Messages | Collapse All Messages