Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 6552060: code review 6552060: effective_go: s/usr/home/ in example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by r
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, dsymonds, rsc
Visibility:
Public.

Description

effective_go: s/usr/home/ in example When I was a lad (and well past), users were in /usr; now they're somewhere else, I'm told. Kids today. Fixes issue 4122.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 5a92a8a1509d https://code.google.com/p/go/ #

Patch Set 3 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/effective_go.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2012-09-22 19:02:47 UTC) #1
dsymonds
LGTM pesky kids
11 years, 6 months ago (2012-09-22 23:25:14 UTC) #2
rsc
LGTM http://codereview.appspot.com/6552060/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/6552060/diff/1/doc/effective_go.html#newcode1777 doc/effective_go.html:1777: HOME = "/home/" + USER Could also just ...
11 years, 6 months ago (2012-09-22 23:49:08 UTC) #3
r
11 years, 6 months ago (2012-09-23 00:45:19 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=99fee67bd747 ***

effective_go: s/usr/home/ in example
When I was a lad (and well past), users were in /usr;
now they're somewhere else, I'm told.
Kids today.

Fixes issue 4122.

R=golang-dev, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/6552060

http://codereview.appspot.com/6552060/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/6552060/diff/1/doc/effective_go.html#newcode1777
doc/effective_go.html:1777: HOME = "/home/" + USER
On 2012/09/22 23:49:08, rsc wrote:
> Could also just delete var USER above and make this one the log.Fatal and
bypass
> any needing to decide where home directories are.

That would make the example less interesting. I'll leave it as is.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b