Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5115)

Issue 6551050: Set up indent-tabs-mode in lexer.ll and parser.yy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dak
Modified:
11 years, 7 months ago
Reviewers:
janek, joeneeman
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Set up indent-tabs-mode in lexer.ll and parser.yy indent-tabs-mode has been switched off for C++ files with directory-local variables. However, for lack of working better indentation modes that cooperate well with Bison and Flex files, lexer.ll and parser.yy are using a tab-based indentation style oriented on the Linux kernel indentation style. In order to not cause an even greater inconsistent mess, local file variables are used for switching tab-based indentation back on in those files.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lily/lexer.ll View 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
joeneeman
lgtm
11 years, 7 months ago (2012-09-25 23:59:21 UTC) #1
janek
Do i understand correctly that this is something for Emacs' sake? If so, please add ...
11 years, 7 months ago (2012-09-26 05:24:37 UTC) #2
dak
On 2012/09/26 05:24:37, janek wrote: > Do i understand correctly that this is something for ...
11 years, 7 months ago (2012-09-26 06:32:15 UTC) #3
janek
11 years, 7 months ago (2012-09-26 06:36:57 UTC) #4
On 2012/09/26 06:32:15, dak wrote:
> will do.

thanks, and LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b