Issue 6550056: note-collision: retain upper voice dot when merging dots

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6550056: note-collision: retain upper voice dot when merging dots (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Keith

Modified:
11 years, 5 months ago

Reviewers:
janek, joeneeman

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

note-collision: retain upper voice dot when merging dots

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/note-collision.cc	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

joeneeman

lgtm http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc#newcode251 lily/note-collision.cc:251: dot_wipe_head = head_down; Comment, please? (eg. it would ...

11 years, 7 months ago (2012-09-26 00:12:27 UTC) #1

Keith

http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc#newcode234 lily/note-collision.cc:234: different heads, dots on the smaller one disappear. */ ...

11 years, 7 months ago (2012-09-26 02:52:10 UTC) #2

lgtm :)

Expand All Messages | Collapse All Messages