Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 6549052: code review 6549052: cmd/8g: use SSE2 instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 3 months ago
CC:
golang-dev
Visibility:
Public.

Description

cmd/8g: use SSE2 instructions The SSE2 instructions use a register set instead of a virtual stack, which makes the resulting code more amenable to traditional registerization. This change ends support for pre-2001 (pre-Pentium 4) chips. The previous cutoff had been 1993 (Pentium MMX), for sync/atomic. fasta -n 25000000 gcc -m32 -O2 fasta.c 3.99u 0.00s 3.99r - gc fasta 3.08u 0.02s 3.10r + gc fasta 2.37u 0.01s 2.38r -23% nbody -n 50000000 gcc -m32 -O2 nbody.c 13.70u 0.00s 13.71r - gc nbody 21.86u 0.00s 21.88r + gc nbody 14.63u 0.00s 14.64r -33% spectral-norm 5500 gcc -m32 -O2 spectral*.c 10.49u 0.01s 10.51r - gc spectral-norm 20.79u 0.00s 20.81r + gc spectral-norm 17.05u 0.00s 17.07r -18% mandelbrot 16000 gcc -m32 -O2 mandelbrot.c 32.17u 0.02s 32.22r - gc mandelbrot 64.80u 0.00s 64.85r + gc mandelbrot 37.32u 0.00s 37.35r -42% Fixes issue 3912.

Patch Set 1 #

Patch Set 2 : diff -r b4d17e91718d https://code.google.com/p/go/ #

Patch Set 3 : diff -r b4d17e91718d https://code.google.com/p/go/ #

Patch Set 4 : diff -r d91e3e7106aa https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 3e660456f301 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r b77af9fe6f56 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 7 : diff -r b77af9fe6f56 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 25dcee3d220c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -330 lines) Patch
M src/cmd/8g/cgen.c View 1 2 3 4 5 6 7 11 chunks +50 lines, -100 lines 0 comments Download
M src/cmd/8g/gsubr.c View 1 2 3 4 5 6 7 22 chunks +157 lines, -224 lines 0 comments Download
M src/cmd/8g/list.c View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/cmd/8g/peep.c View 1 2 3 4 5 9 chunks +63 lines, -1 line 0 comments Download
M src/cmd/8g/reg.c View 1 2 3 4 5 12 chunks +76 lines, -5 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
http://codereview.appspot.com/6549052/diff/6001/src/cmd/8g/reg.c File src/cmd/8g/reg.c (right): http://codereview.appspot.com/6549052/diff/6001/src/cmd/8g/reg.c#newcode820 src/cmd/8g/reg.c:820: if(r >= D_X0 && r <= D_X0+15) maybe harmless ...
11 years, 7 months ago (2012-09-23 11:20:37 UTC) #1
rsc
Hello ken2, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-10-07 19:35:16 UTC) #2
bradfitz
https://codereview.appspot.com/6549052/diff/12001/src/cmd/8g/cgen.c File src/cmd/8g/cgen.c (right): https://codereview.appspot.com/6549052/diff/12001/src/cmd/8g/cgen.c#newcode52 src/cmd/8g/cgen.c:52: Node *nl, *nr, *r, n1, n2, nt; // , ...
11 years, 6 months ago (2012-10-07 19:39:33 UTC) #3
rsc
Done, thanks.
11 years, 6 months ago (2012-10-07 19:49:37 UTC) #4
rsc
11 years, 3 months ago (2013-01-02 22:13:48 UTC) #5
Closing. Remy fixed this better.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b