Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1813)

Issue 6542059: code review 6542059: cmd/gc: prepare for 64-bit ints (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
CC:
ken2, dfc, remyoudompheng, golang-dev
Visibility:
Public.

Description

cmd/gc: prepare for 64-bit ints This CL makes the compiler understand that the type of the len or cap of a map, slice, or string is 'int', not 'int32'. It does not change the meaning of int, but it should make the eventual change of the meaning of int in 6g a bit smoother. Update issue 2188.

Patch Set 1 #

Patch Set 2 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6fdbfbfa8813 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r 4fc7066facc4 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 37da9f82ecac https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -78 lines) Patch
M src/cmd/5g/galign.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 13 chunks +16 lines, -16 lines 0 comments Download
M src/cmd/6g/galign.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/gg.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6g/gobj.c View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 2 6 chunks +11 lines, -11 lines 0 comments Download
M src/cmd/6g/reg.c View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/cmd/8g/galign.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/align.c View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/cmd/gc/gen.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/obj.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/reflect.c View 1 2 4 chunks +15 lines, -15 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M src/cmd/gc/sinit.c View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2012-09-24 02:51:56 UTC) #1
dfc
Thank you, I wonder how many undecorated '4's are left. http://codereview.appspot.com/6542059/diff/4001/src/cmd/6g/gobj.c File src/cmd/6g/gobj.c (right): http://codereview.appspot.com/6542059/diff/4001/src/cmd/6g/gobj.c#newcode392 ...
11 years, 6 months ago (2012-09-24 04:14:54 UTC) #2
rsc
On Mon, Sep 24, 2012 at 12:14 AM, <dave@cheney.net> wrote: > Thank you, I wonder ...
11 years, 6 months ago (2012-09-24 04:23:55 UTC) #3
remyoudompheng
http://codereview.appspot.com/6542059/diff/4001/src/cmd/gc/sinit.c File src/cmd/gc/sinit.c (right): http://codereview.appspot.com/6542059/diff/4001/src/cmd/gc/sinit.c#newcode406 src/cmd/gc/sinit.c:406: gdata(&n1, r->right, 4); missing widthint http://codereview.appspot.com/6542059/diff/4001/src/cmd/gc/sinit.c#newcode408 src/cmd/gc/sinit.c:408: gdata(&n1, r->right, ...
11 years, 6 months ago (2012-09-24 05:42:07 UTC) #4
rsc
> http://codereview.appspot.com/6542059/diff/4001/src/cmd/gc/sinit.c#newcode406 > src/cmd/gc/sinit.c:406: gdata(&n1, r->right, 4); > missing widthint > > http://codereview.appspot.com/6542059/diff/4001/src/cmd/gc/sinit.c#newcode408 > src/cmd/gc/sinit.c:408: ...
11 years, 6 months ago (2012-09-24 16:37:27 UTC) #5
rsc
11 years, 6 months ago (2012-09-24 19:00:00 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=1e0921517418 ***

cmd/gc: prepare for 64-bit ints

This CL makes the compiler understand that the type of
the len or cap of a map, slice, or string is 'int', not 'int32'.
It does not change the meaning of int, but it should make
the eventual change of the meaning of int in 6g a bit smoother.

Update issue 2188.

R=ken, dave, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/6542059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b