code review 6540045: vet: fix rangeloop.

vet: fix rangeloop.

In a range loop, the presence of a value implies the presence of a key.
However, the presence of a value as an *ast.Ident does not imply that
the key is also an *ast.Ident, thus leading to a panic any time the
two argument form is used where the key is not an identifier.

[dsymonds, 2012-09-19 13:04:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2012-09-19 13:05:54]

Also, how the heck do you run this to check against // ERROR lines?
"go run ../../../test/run.go -v -summary -- ./rangeloop.go" does not
do anything useful.

[adg, 2012-09-19 17:04:49]

LGTM

Thanks Dave.

[r, 2012-09-19 18:07:53]

On Wed, Sep 19, 2012 at 6:05 AM, David Symonds <dsymonds@golang.org> wrote:
> Also, how the heck do you run this to check against // ERROR lines?
> "go run ../../../test/run.go -v -summary -- ./rangeloop.go" does not
> do anything useful.

cd src/cmd/vet
make test

[dsymonds, 2012-09-19 22:12:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=357285dcdff5 ***

vet: fix rangeloop.

In a range loop, the presence of a value implies the presence of a key.
However, the presence of a value as an *ast.Ident does not imply that
the key is also an *ast.Ident, thus leading to a panic any time the
two argument form is used where the key is not an identifier.

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/6540045