CONTRIBUTORS changes must be done separately. Remove that part from the CL and we can ...
11 years, 7 months ago
(2012-09-18 17:27:27 UTC)
#2
CONTRIBUTORS changes must be done separately.
Remove that part from the CL and we can do the AUTHORS and CONTRIBUTORS
part.
On Tue, Sep 18, 2012 at 8:08 AM, <anthony.eufemio@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> builtin: Changed documentation for rune type.
> Fixes issue 4093.
>
> Please review this at
http://codereview.appspot.com/**6536047/<http://codereview.appspot.com/6536047/>
>
> Affected files:
> M CONTRIBUTORS
> M src/pkg/builtin/builtin.go
>
>
> Index: CONTRIBUTORS
> ==============================**==============================**=======
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -54,6 +54,7 @@
> Andy Davis <andy@bigandian.com>
> Anh Hai Trinh <anh.hai.trinh@gmail.com>
> Anschel Schaffer-Cohen <anschelsc@gmail.com>
> +Anthony Eufemio <anthony.eufemio@gmail.com>
> Anthony Martin <ality@pbrane.org>
> Anthony Starks <ajstarks@gmail.com>
> Aron Nopanen <aron.nopanen@gmail.com>
> Index: src/pkg/builtin/builtin.go
> ==============================**==============================**=======
> --- a/src/pkg/builtin/builtin.go
> +++ b/src/pkg/builtin/builtin.go
> @@ -81,9 +81,8 @@
> // integer values.
> type byte byte
>
> -// rune is an alias for int and is equivalent to int in all ways. It is
> +// rune is an alias for int32 and is equivalent to int32 in all ways. It
> is
> // used, by convention, to distinguish character values from integer
> values.
> -// In a future version of Go, it will change to an alias of int32.
> type rune rune
>
> // Type is here for the purposes of documentation only. It is a stand-in
>
>
>
Also, it looks like you haven't submitted the CLA. See http://golang.org/doc/contribute.html#copyright On Tue, Sep 18, ...
11 years, 7 months ago
(2012-09-18 17:28:17 UTC)
#3
Also, it looks like you haven't submitted the CLA.
See http://golang.org/doc/contribute.html#copyright
On Tue, Sep 18, 2012 at 8:08 AM, <anthony.eufemio@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> builtin: Changed documentation for rune type.
> Fixes issue 4093.
>
> Please review this at
http://codereview.appspot.com/**6536047/<http://codereview.appspot.com/6536047/>
>
> Affected files:
> M CONTRIBUTORS
> M src/pkg/builtin/builtin.go
>
>
> Index: CONTRIBUTORS
> ==============================**==============================**=======
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -54,6 +54,7 @@
> Andy Davis <andy@bigandian.com>
> Anh Hai Trinh <anh.hai.trinh@gmail.com>
> Anschel Schaffer-Cohen <anschelsc@gmail.com>
> +Anthony Eufemio <anthony.eufemio@gmail.com>
> Anthony Martin <ality@pbrane.org>
> Anthony Starks <ajstarks@gmail.com>
> Aron Nopanen <aron.nopanen@gmail.com>
> Index: src/pkg/builtin/builtin.go
> ==============================**==============================**=======
> --- a/src/pkg/builtin/builtin.go
> +++ b/src/pkg/builtin/builtin.go
> @@ -81,9 +81,8 @@
> // integer values.
> type byte byte
>
> -// rune is an alias for int and is equivalent to int in all ways. It is
> +// rune is an alias for int32 and is equivalent to int32 in all ways. It
> is
> // used, by convention, to distinguish character values from integer
> values.
> -// In a future version of Go, it will change to an alias of int32.
> type rune rune
>
> // Type is here for the purposes of documentation only. It is a stand-in
>
>
>
The CLA is now in and verified. On Tue, Sep 18, 2012 at 10:33 AM, ...
11 years, 7 months ago
(2012-09-18 17:34:33 UTC)
#5
The CLA is now in and verified.
On Tue, Sep 18, 2012 at 10:33 AM, Rob Pike <r@golang.org> wrote:
> Alternatively, for a change this small if you'd prefer we could just
> make it for you, with thanks.
>
> -rob
>
Issue 6536047: code review 6536047: builtin: Changed documentation for rune type.
Created 11 years, 7 months ago by anthony.eufemio
Modified 11 years, 7 months ago
Reviewers:
Base URL:
Comments: 0