code review 6528047: api: fix build; regenerate api.txt with fixed signatures

api: fix build; regenerate api.txt with fixed signatures

Update to tip (to get 6475062 and 6525047)
Rebuild cmd/api.
Switch to a go1 release branch.
Run go tool api > api/go1.txt.new in release branch.
Back to tip.

[bradfitz, 2012-09-18 23:05:11]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2012-09-19 00:14:42]

LGTM
Thanks!

[bradfitz, 2012-09-19 05:04:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=7cbb8aa08f8e ***

api: fix build; regenerate api.txt with fixed signatures

Update to tip (to get 6475062 and 6525047)
Rebuild cmd/api.
Switch to a go1 release branch.
Run go tool api > api/go1.txt.new in release branch.
Back to tip.

R=golang-dev, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/6528047

[adg, 2012-09-21 18:29:37]

Should these changes be merged into release-branch.go1?

[bradfitz, 2012-09-21 18:32:00]

Only if the corresponding cmd/api fixes are too.  Either way probably.

On Fri, Sep 21, 2012 at 11:29 AM, Andrew Gerrand <adg@golang.org> wrote:

> Should these changes be merged into release-branch.go1?
>

[adg, 2012-09-21 18:39:23]

go1.txt didn't merge, because the release-branch.go1 version and the
default version have gotten out of sync. I guess it's because of these
changes that were only applied to the release-branch?

changeset:   13336:e3a0ea8c7389
branch:      release-branch.go1
user:        Shenghou Ma <minux.ma@gmail.com>
date:        Wed Jun 13 16:24:39 2012 -0400
summary:     [release-branch.go1] api: add Linux/ARM to go1 API

changeset:   13331:d92d483b2eb2
branch:      release-branch.go1
user:        Brad Fitzpatrick <bradfitz@golang.org>
date:        Wed Jun 13 16:24:34 2012 -0400
summary:     [release-branch.go1] api: add FreeBSD to go1 API

and Russ' recent change:

changeset:   14122:248e11862ed5
user:        Russ Cox <rsc@golang.org>
date:        Tue Sep 18 15:57:03 2012 -0400
summary:     cmd/api: allow extension of interfaces with unexported methods

Should the two branches be brought back in sync?

On 21 September 2012 11:31, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Only if the corresponding cmd/api fixes are too.  Either way probably.
>
>
> On Fri, Sep 21, 2012 at 11:29 AM, Andrew Gerrand <adg@golang.org> wrote:
>>
>> Should these changes be merged into release-branch.go1?
>
>

[bradfitz, 2012-09-21 18:49:47]

Fine by me.  It's not like regular users will be using cmd/api anyway, so
updating it from tip seems harmless.

On Fri, Sep 21, 2012 at 11:38 AM, Andrew Gerrand <adg@golang.org> wrote:

> go1.txt didn't merge, because the release-branch.go1 version and the
> default version have gotten out of sync. I guess it's because of these
> changes that were only applied to the release-branch?
>
> changeset:   13336:e3a0ea8c7389
> branch:      release-branch.go1
> user:        Shenghou Ma <minux.ma@gmail.com>
> date:        Wed Jun 13 16:24:39 2012 -0400
> summary:     [release-branch.go1] api: add Linux/ARM to go1 API
>
> changeset:   13331:d92d483b2eb2
> branch:      release-branch.go1
> user:        Brad Fitzpatrick <bradfitz@golang.org>
> date:        Wed Jun 13 16:24:34 2012 -0400
> summary:     [release-branch.go1] api: add FreeBSD to go1 API
>
> and Russ' recent change:
>
> changeset:   14122:248e11862ed5
> user:        Russ Cox <rsc@golang.org>
> date:        Tue Sep 18 15:57:03 2012 -0400
> summary:     cmd/api: allow extension of interfaces with unexported methods
>
> Should the two branches be brought back in sync?
>
> On 21 September 2012 11:31, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> > Only if the corresponding cmd/api fixes are too.  Either way probably.
> >
> >
> > On Fri, Sep 21, 2012 at 11:29 AM, Andrew Gerrand <adg@golang.org> wrote:
> >>
> >> Should these changes be merged into release-branch.go1?
> >
> >
>