The enclosed patch fixes yet another bug with the gdb-index v7 flag byte by reporting ...
12 years, 7 months ago
(2012-09-11 23:18:38 UTC)
#1
The enclosed patch fixes yet another bug with the gdb-index v7 flag byte
by reporting certain structs and types as static only for non-C++ and
non-java.
OK for Google 4.7?
Sterling
2012-09-11 Sterling Augustine <saugustine@google.com>
* dwarf2out.c (output_pubname):
Index: dwarf2out.c
===================================================================
--- dwarf2out.c (revision 191203)
+++ dwarf2out.c (working copy)
@@ -9484,7 +9484,8 @@ output_pubname (dw_offset die_offset, pubname_entr
case DW_TAG_union_type:
case DW_TAG_enumeration_type:
GDB_INDEX_SYMBOL_KIND_SET_VALUE(flags, GDB_INDEX_SYMBOL_KIND_TYPE);
- GDB_INDEX_SYMBOL_STATIC_SET_VALUE(flags, 1);
+ if (!is_cxx () && !is_java ())
+ GDB_INDEX_SYMBOL_STATIC_SET_VALUE(flags, 1);
break;
default:
/* For unrecognized TAGs, don't set the flags. */
--
This patch is available for review at http://codereview.appspot.com/6506098
> The enclosed patch fixes yet another bug with the gdb-index v7 flag byte > ...
12 years, 7 months ago
(2012-09-12 00:13:08 UTC)
#2
> The enclosed patch fixes yet another bug with the gdb-index v7 flag byte
> by reporting certain structs and types as static only for non-C++ and
> non-java.
>
> OK for Google 4.7?
>
> Sterling
>
> 2012-09-11 Sterling Augustine <saugustine@google.com>
>
> * dwarf2out.c (output_pubname):
OK for google/gcc-4_7.
-cary
On Tue, Sep 11, 2012 at 5:13 PM, Cary Coutant <ccoutant@google.com> wrote: >> The enclosed ...
12 years, 7 months ago
(2012-09-12 00:19:23 UTC)
#3
On Tue, Sep 11, 2012 at 5:13 PM, Cary Coutant <ccoutant@google.com> wrote:
>> The enclosed patch fixes yet another bug with the gdb-index v7 flag byte
>> by reporting certain structs and types as static only for non-C++ and
>> non-java.
>>
>> OK for Google 4.7?
>>
>> Sterling
>>
>> 2012-09-11 Sterling Augustine <saugustine@google.com>
>>
>> * dwarf2out.c (output_pubname):
>
> OK for google/gcc-4_7.
Committed as r191207.
Sterling
Issue 6506098: [Google 4.7] Fix static bit for C++ structs in gdb-index v7
Created 12 years, 7 months ago by saugustine
Modified 12 years, 7 months ago
Reviewers: Cary
Base URL: svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/gcc/
Comments: 0