Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1619)

Issue 6506063: code review 6506063: syscall: add GetsockoptInt, GetsockoptInet4Addr for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by mikio
Modified:
11 years, 6 months ago
Reviewers:
brainman
CC:
golang-dev
Visibility:
Public.

Description

syscall: add GetsockoptInt, GetsockoptInet4Addr for windows

Patch Set 1 #

Patch Set 2 : diff -r 5c4859bc123f https://code.google.com/p/go #

Patch Set 3 : diff -r 4965beed4492 https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r 91c1c2d6e2ff https://code.google.com/p/go #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
A src/pkg/syscall/socket_windows_test.go View 1 2 3 1 chunk +49 lines, -0 lines 1 comment Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 2 chunks +20 lines, -6 lines 2 comments Download

Messages

Total messages: 13
mikio
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2012-09-04 03:32:49 UTC) #1
brainman
Your new test fails: --- FAIL: TestIPv4SocketOptions (0.00 seconds) socket_windows_test.go:15: syscall.Socket failed: Either the application ...
11 years, 6 months ago (2012-09-04 06:50:09 UTC) #2
mikio
Thanks for your review. On 2012/09/04 06:50:09, brainman wrote: > Your new test fails: > ...
11 years, 6 months ago (2012-09-04 09:07:26 UTC) #3
brainman
On 2012/09/04 09:07:26, mikio wrote: > > > > --- FAIL: TestIPv4SocketOptions (0.00 seconds) > ...
11 years, 6 months ago (2012-09-05 00:23:42 UTC) #4
mikio
Thanks for the comments. On Wed, Sep 5, 2012 at 9:23 AM, <alex.brainman@gmail.com> wrote: >> ...
11 years, 6 months ago (2012-09-05 04:08:45 UTC) #5
brainman
On 2012/09/05 04:08:45, mikio wrote: > > I guess it's not commonality, I just need ...
11 years, 6 months ago (2012-09-05 04:30:16 UTC) #6
mikio
On 2012/09/05 04:30:16, brainman wrote: > If it saves some code somewhere else, then I ...
11 years, 6 months ago (2012-09-06 11:38:14 UTC) #7
mikio
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-06 11:38:39 UTC) #8
brainman
Sorry, but I still fail to see the need for these changes. Perhaps, we could ...
11 years, 6 months ago (2012-09-07 01:55:42 UTC) #9
mikio
On Fri, Sep 7, 2012 at 10:55 AM, <alex.brainman@gmail.com> wrote: > Sorry, but I still ...
11 years, 6 months ago (2012-09-07 04:01:30 UTC) #10
brainman
On 2012/09/07 04:01:30, mikio wrote: > > Do you have any suggestions or ideas? Once ...
11 years, 6 months ago (2012-09-07 04:31:12 UTC) #11
mikio
On 2012/09/07 04:31:12, brainman wrote: > Once something is in the main Go tree, it ...
11 years, 6 months ago (2012-09-07 06:04:22 UTC) #12
mikio
11 years, 6 months ago (2012-09-07 07:52:42 UTC) #13
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b