Issue 6506061: code review 6506061: syscall: Test SCM credentials on Linux.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506061: code review 6506061: syscall: Test SCM credentials on Linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by albert.strasheim

Modified:
12 years, 4 months ago

Reviewers:

CC:
bradfitz, rsc, mikio, golang-dev

Visibility:
Public.

Description

syscall: Test SCM credentials on Linux. This test was previously removed in 087c6e15702e.

Patch Set 1 #

Patch Set 2 : diff -r 827bc3cff650 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 827bc3cff650 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 827bc3cff650 https://code.google.com/p/go/ #

Patch Set 5 : diff -r f06edb3fcffe https://code.google.com/p/go/ #

Patch Set 6 : diff -r f06edb3fcffe https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -0 lines)			Patch
	A	src/pkg/syscall/creds_test.go	View	1 2 3 4	1 chunk	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

albert.strasheim

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2012-09-01 10:01:38 UTC) #1

rsc

I suspect this should be called creds_test.go and have a // +build line restricting it ...

12 years, 11 months ago (2012-09-01 14:02:14 UTC) #2

albert.strasheim

Hello bradfitz@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 11 months ago (2012-09-06 07:37:46 UTC) #3

bradfitz

LGTM creds_unix_test.go seems unnecessarily long. creds_test.go and the +build line works. On Thu, Sep 6, ...

12 years, 11 months ago (2012-09-07 17:28:50 UTC) #5

bradfitz

12 years, 11 months ago (2012-09-07 17:31:27 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=7fa140566591 ***

syscall: Test SCM credentials on Linux.

This test was previously removed in 087c6e15702e.

R=bradfitz, rsc, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/6506061

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages