code review 6501064: goprotobuf: Fix Marshal crash on typed nil.

goprotobuf: Fix Marshal crash on typed nil.

Also a bunch of other trivial updates.

[dsymonds, 2012-08-30 02:44:12]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/goprotobuf

[r, 2012-08-30 04:19:46]

http://codereview.appspot.com/6501064/diff/4001/proto/clone.go
File proto/clone.go (right):

http://codereview.appspot.com/6501064/diff/4001/proto/clone.go#newcode41
proto/clone.go:41: "log"
why is this reordered?

http://codereview.appspot.com/6501064/diff/4001/proto/equal.go
File proto/equal.go (right):

http://codereview.appspot.com/6501064/diff/4001/proto/equal.go#newcode42
proto/equal.go:42: "log"
ditto

http://codereview.appspot.com/6501064/diff/4001/proto/lib.go
File proto/lib.go (right):

http://codereview.appspot.com/6501064/diff/4001/proto/lib.go#newcode208
proto/lib.go:208: "log"
ditto

http://codereview.appspot.com/6501064/diff/4001/proto/text.go
File proto/text.go (right):

http://codereview.appspot.com/6501064/diff/4001/proto/text.go#newcode95
proto/text.go:95: log.Printf("proto: textWriter unindented too far")
you want this return

http://codereview.appspot.com/6501064/diff/4001/protoc-gen-go/generator/gener...
File protoc-gen-go/generator/generator.go (right):

http://codereview.appspot.com/6501064/diff/4001/protoc-gen-go/generator/gener...
protoc-gen-go/generator/generator.go:55: "log"
again

[dsymonds, 2012-08-30 04:23:31]

http://codereview.appspot.com/6501064/diff/4001/proto/text.go
File proto/text.go (right):

http://codereview.appspot.com/6501064/diff/4001/proto/text.go#newcode95
proto/text.go:95: log.Printf("proto: textWriter unindented too far")
On 2012/08/30 04:19:47, r wrote:
> you want this return

Done.

[dsymonds, 2012-08-30 05:11:55]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-08-30 05:12:53]

LGTM

[dsymonds, 2012-08-30 05:17:58]

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=6d035089ba19 ***

goprotobuf: Fix Marshal crash on typed nil.

Also a bunch of other trivial updates.

R=r
CC=golang-dev
http://codereview.appspot.com/6501064