Issue 6500136: code review 6500136: misc/dashboard/builder: reinstate 'go get -d' erro hand...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6500136: code review 6500136: misc/dashboard/builder: reinstate 'go get -d' erro hand... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by adg

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, minux1

Visibility:
Public.

Description

misc/dashboard/builder: reinstate 'go get -d' error handling hack I thought this was redundant since the behavior of 'go get -d' had changed. I was wrong. Should have tested more thoroughly.

Patch Set 1 #

Patch Set 2 : diff -r 4b10b73006ec https://go.googlecode.com/hg #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	misc/dashboard/builder/main.go	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 9 months ago (2012-09-17 18:08:24 UTC) #1

adg

12 years, 9 months ago (2012-09-17 18:21:02 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f48f1de09de5 ***

misc/dashboard/builder: reinstate 'go get -d' error handling hack

I thought this was redundant since the behavior of 'go get -d' had
changed. I was wrong. Should have tested more thoroughly.

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6500136

Expand All Messages | Collapse All Messages