Issue 6500069: part-combiner.scm: replace use of "when" with "moment"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6500069: part-combiner.scm: replace use of "when" with "moment" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dak

Modified:
11 years, 7 months ago

Reviewers:
Keith, Ian Hulin (gmail)

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

part-combiner.scm: replace use of "when" with "moment" "when" is already a macro in Guilev2.

Patch Set 2 : Removed use-module call, no significant change. Can't corroborate programming errors. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
	M	scm/part-combiner.scm	View	1	11 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Keith

Maybe best in this case to test without patchy and push. http://codereview.appspot.com/6500069/diff/1/scm/part-combiner.scm File scm/part-combiner.scm (right): ...

11 years, 8 months ago (2012-09-03 20:14:24 UTC) #1

dak

http://codereview.appspot.com/6500069/diff/1/scm/part-combiner.scm File scm/part-combiner.scm (right): http://codereview.appspot.com/6500069/diff/1/scm/part-combiner.scm#newcode21 scm/part-combiner.scm:21: (use-modules (oop goops)) On 2012/09/03 20:14:24, Keith wrote: > ...

11 years, 8 months ago (2012-09-03 22:46:51 UTC) #2

Ian Hulin (gmail)

11 years, 8 months ago (2012-09-04 23:06:44 UTC) #3

LGTM.
Very similar to the hack I have on my GuileV2 sandbox on my netbook. If
partcombine regtests run OK, it's a go.

Expand All Messages | Collapse All Messages