code review 6499127: misc/dashboard/builder: increase default command timeout

misc/dashboard/builder: increase default command timeout

[adg, 2012-09-17 17:53:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitz, 2012-09-17 17:59:07]

LGTM

I thought you had it at 30 minutes initially.

On Mon, Sep 17, 2012 at 10:53 AM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> misc/dashboard/builder: increase default command timeout
>
> Please review this at
http://codereview.appspot.com/**6499127/<http://codereview.appspot.com/6499127/>
>
> Affected files:
>   M misc/dashboard/builder/main.go
>
>
> Index: misc/dashboard/builder/main.go
> ==============================**==============================**=======
> --- a/misc/dashboard/builder/main.**go
> +++ b/misc/dashboard/builder/main.**go
> @@ -55,7 +55,7 @@
>         failAll       = flag.Bool("fail", false, "fail all builds")
>         parallel      = flag.Bool("parallel", false, "Build multiple
> targets in parallel")
>         buildTimeout  = flag.Duration("buildTimeout", 60*time.Minute,
> "Maximum time to wait for builds and tests")
> -       cmdTimeout    = flag.Duration("cmdTimeout", 2*time.Minute,
> "Maximum time to wait for an external command")
> +       cmdTimeout    = flag.Duration("cmdTimeout", 5*time.Minute,
> "Maximum time to wait for an external command")
>         verbose       = flag.Bool("v", false, "verbose")
>  )
>
>
>
>

[adg, 2012-09-17 18:05:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=6c9c22a4b5c5 ***

misc/dashboard/builder: increase default command timeout

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6499127