Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 6498053: Cache all pure minimum translations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by MikeSol
Modified:
11 years, 5 months ago
Reviewers:
Keith, mike7
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Cache all pure minimum translations I'm getting mixed results for this - I can't tell if it's leading to a uniform speed-up on all scores or not. What I need most from people are runs on every sort of score possible. I'm averaging about a 7% speed up but it's not statistically significant.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M lily/align-interface.cc View 4 chunks +21 lines, -15 lines 0 comments Download
M scm/define-grob-properties.scm View 2 chunks +2 lines, -2 lines 0 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3
Keith
I tried in on a score where should have its largest effect, a 41-page score ...
11 years, 8 months ago (2012-08-29 21:25:18 UTC) #1
Keith
> I'm averaging about a 7% speed up > but it's not statistically significant. What ...
11 years, 8 months ago (2012-08-31 06:35:26 UTC) #2
mike7
11 years, 8 months ago (2012-08-31 07:20:43 UTC) #3
On 31 août 2012, at 08:35, k-ohara5a5a@oco.net wrote:

>>  I'm averaging about a 7% speed up
>>  but it's not statistically significant.
> 
> What types of scores get slower ?
> 
> http://codereview.appspot.com/6498053/
> 
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel

It's just erratic - sometimes I'll run it and it'll be the same speed, sometimes
I see a speed up.  My computer has all sorts of cruft hogging memory, so it's
tough for me to accurately evaluate if there is a speed up.  There's only been a
slow-down once, though, and it was on a score that almost always showed
speed-ups (a Mozart horn concerto I use regularly for tests).

So if you're finding that the patch categorically speeds things up, all is
well.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b