Issue 6497102: code review 6497102: lib9: remove ss_len manipulation in _p9dialparse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497102: code review 6497102: lib9: remove ss_len manipulation in _p9dialparse (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

lib9: remove ss_len manipulation in _p9dialparse Not all systems have ss_len, and we've never set it before.

Patch Set 1 #

Patch Set 2 : diff -r f73f782195af https://code.google.com/p/plan9port #

Patch Set 3 : diff -r f73f782195af https://code.google.com/p/plan9port #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	src/lib9/_p9dialparse.c	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

12 years, 4 months ago (2012-09-08 17:53:57 UTC) #1

rsc

12 years, 4 months ago (2012-09-08 17:54:03 UTC) #2

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=f6c19873a236
***

lib9: remove ss_len manipulation in _p9dialparse

Not all systems have ss_len, and we've never set it before.

R=rsc
http://codereview.appspot.com/6497102

Expand All Messages | Collapse All Messages