Descriptioncrypto/tls: fix data race on conn.err
Fixes issue 3862.
There were many areas where conn.err was being accessed
outside the mutex. This proposal moves the err value to
an embedded struct to make it more obvious when the error
value is being accessed.
As there are no Benchmark tests in this package I cannot
feel confident of the impact of this additional locking,
although most will be uncontended.
Patch Set 1 #Patch Set 2 : diff -r e6da0262840c https://code.google.com/p/go #Patch Set 3 : diff -r 957c047e5586 https://code.google.com/p/go #Patch Set 4 : diff -r 957c047e5586 https://code.google.com/p/go #
Total comments: 4
Patch Set 5 : diff -r 957c047e5586 https://code.google.com/p/go #Patch Set 6 : diff -r 292816148e44 https://code.google.com/p/go #Patch Set 7 : diff -r f06edb3fcffe https://go.googlecode.com/hg/ #MessagesTotal messages: 7
|