code review 6495059: path: improve documentation for Dir

path: improve documentation for Dir

[r, 2012-08-29 22:20:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-08-29 22:34:01]

LGTM

On Wed, Aug 29, 2012 at 3:20 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> path: improve documentation for Dir
>
> Please review this at
http://codereview.appspot.com/**6495059/<http://codereview.appspot.com/6495059/>
>
> Affected files:
>   M src/pkg/path/path.go
>   M src/pkg/path/path_test.go
>
>
> Index: src/pkg/path/path.go
> ==============================**==============================**=======
> --- a/src/pkg/path/path.go
> +++ b/src/pkg/path/path.go
> @@ -198,7 +198,8 @@
>  }
>
>  // Dir returns all but the last element of path, typically the path's
> directory.
> -// The path is Cleaned and trailing slashes are removed before processing.
> +// After dropping the final element using Split, the path is Cleaned and
> trailing
> +// slashes are removed.
>  // If the path is empty, Dir returns ".".
>  // If the path consists entirely of slashes followed by non-slash bytes,
> Dir
>  // returns a single slash. In any other case, the returned path does not
> end in a
> Index: src/pkg/path/path_test.go
> ==============================**==============================**=======
> --- a/src/pkg/path/path_test.go
> +++ b/src/pkg/path/path_test.go
> @@ -200,6 +200,7 @@
>         {"x/", "x"},
>         {"abc", "."},
>         {"abc/def", "abc"},
> +       {"abc////def", "abc"},
>         {"a/b/.x", "a/b"},
>         {"a/b/c.", "a/b"},
>         {"a/b/c.x", "a/b"},
>
>
>

[r, 2012-08-30 18:16:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=735963d94dad ***

path: improve documentation for Dir

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6495059