Issue 6494071: default position for a time signature is unconditionally 0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6494071: default position for a time signature is unconditionally 0

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by benko.pal

Modified:
11 years, 7 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

default position for a time signature is unconditionally 0

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused include's #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	lily/time-signature.cc	View	1	2 chunks	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

11 years, 7 months ago (2012-09-01 22:51:59 UTC) #1

lgtm

http://codereview.appspot.com/6494071/diff/1/lily/time-signature.cc
File lily/time-signature.cc (left):

http://codereview.appspot.com/6494071/diff/1/lily/time-signature.cc#oldcode26
lily/time-signature.cc:26: #include "staff-symbol.hh"
no longer need "staff-symbol.hh"

Expand All Messages | Collapse All Messages