Issue 6492117: code review 6492117: build: print go banner before restoring windows PATH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492117: code review 6492117: build: print go banner before restoring windows PATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bradfitz

Modified:
12 years, 7 months ago

Reviewers:
minux1, brainman

CC:
golang-dev, r

Visibility:
Public.

Description

build: print go banner before restoring windows PATH

Patch Set 1 #

Patch Set 2 : diff -r 0b67641b4d2f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0b67641b4d2f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0b67641b4d2f https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/all.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-09-13 19:34:58 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=452fc24c7ed3 *** build: print go banner before restoring windows PATH R=golang-dev, r ...

12 years, 8 months ago (2012-09-13 19:39:46 UTC) #3

minux1

12 years, 7 months ago (2012-09-19 12:27:08 UTC) #5

Just saw this.

On Fri, Sep 14, 2012 at 3:34 AM, <bradfitz@golang.org> wrote:

> Index: src/all.bat
> ==============================**==============================**=======
> --- a/src/all.bat
> +++ b/src/all.bat
> @@ -16,8 +16,8 @@
>  if %GOBUILDFAIL%==1 goto end
>  call run.bat --no-rebuild --no-local
>  if %GOBUILDFAIL%==1 goto end
> +go tool dist banner
>  set PATH=%OLDPATH%
> -go tool dist banner

i think this change is not correct.

we restore %PATH% before banner so that banner could get the original %PATH%
and suggest the user to add %GOROOT%/bin to %PATH% if necessary.

Expand All Messages | Collapse All Messages