Issue 6492074: code review 6492074: devip: fix addrlen in connect() and bind()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6492074: code review 6492074: devip: fix addrlen in connect() and bind() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by 0intro

Modified:
11 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

devip: fix addrlen in connect() and bind() On some systems, the third argument of connect() and bind() is expected to be the length of the address family instead of the length of the sockaddr structure.

Patch Set 1 #

Patch Set 2 : diff -r a43b5147ae91 https://code.google.com/p/drawterm/ #

Patch Set 3 : diff -r a43b5147ae91 https://code.google.com/p/drawterm/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -6 lines)			Patch
	M	kern/devip-posix.c	View	1	4 chunks	+15 lines, -3 lines	0 comments	Download
	M	kern/devip-win32.c	View	1	4 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

0intro

Hello rsc, I'd like you to review this change to https://code.google.com/p/drawterm/

11 years, 7 months ago (2012-09-03 19:43:38 UTC) #1

0intro

11 years, 7 months ago (2012-09-10 17:52:02 UTC) #3

*** Submitted as http://code.google.com/p/drawterm/source/detail?r=4a8b3bbeab0b
***

devip: fix addrlen in connect() and bind()

On some systems, the third argument of connect() and bind()
is expected to be the length of the address family instead
of the length of the sockaddr structure.

R=rsc
http://codereview.appspot.com/6492074

Expand All Messages | Collapse All Messages