Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 6492074: code review 6492074: devip: fix addrlen in connect() and bind() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by 0intro
Modified:
12 years, 2 months ago
Reviewers:
CC:
rsc
Visibility:
Public.

Description

devip: fix addrlen in connect() and bind() On some systems, the third argument of connect() and bind() is expected to be the length of the address family instead of the length of the sockaddr structure.

Patch Set 1 #

Patch Set 2 : diff -r a43b5147ae91 https://code.google.com/p/drawterm/ #

Patch Set 3 : diff -r a43b5147ae91 https://code.google.com/p/drawterm/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M kern/devip-posix.c View 1 4 chunks +15 lines, -3 lines 0 comments Download
M kern/devip-win32.c View 1 4 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3
0intro
Hello rsc, I'd like you to review this change to https://code.google.com/p/drawterm/
12 years, 2 months ago (2012-09-03 19:43:38 UTC) #1
rsc
LGTM
12 years, 2 months ago (2012-09-10 15:58:53 UTC) #2
0intro
12 years, 2 months ago (2012-09-10 17:52:02 UTC) #3
*** Submitted as http://code.google.com/p/drawterm/source/detail?r=4a8b3bbeab0b
***

devip: fix addrlen in connect() and bind()

On some systems, the third argument of connect() and bind()
is expected to be the length of the address family instead
of the length of the sockaddr structure.

R=rsc
http://codereview.appspot.com/6492074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b