code review 649041: math: add Gamma function

math: add Gamma function

[Charlie Dorian, 2010-03-19 02:03:20]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[Charlie Dorian, 2010-03-19 02:18:45]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[Charlie Dorian, 2010-03-19 15:49:03]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-03-19 20:01:06]

http://codereview.appspot.com/649041/diff/9001/10003
File src/pkg/math/gamma.go (right):

http://codereview.appspot.com/649041/diff/9001/10003#newcode135
src/pkg/math/gamma.go:135: signgam := 1
Looks like 
if x >= 0 {
    return stirling(x)
}
signgam := 1
and then you can unindent the if x < 0 body.

[Charlie Dorian, 2010-03-19 22:24:08]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[Charlie Dorian, 2010-03-19 22:25:09]

Thanks for the review.

On Fri, Mar 19, 2010 at 4:01 PM, <rsc@google.com> wrote:

>
> http://codereview.appspot.com/649041/diff/9001/10003
> File src/pkg/math/gamma.go (right):
>
> http://codereview.appspot.com/649041/diff/9001/10003#newcode135
> src/pkg/math/gamma.go:135: signgam := 1
> Looks like
> if x >= 0 {
>    return stirling(x)
> }
> signgam := 1
> and then you can unindent the if x < 0 body.

Good eye!  Revised.

>
>
> http://codereview.appspot.com/649041/show
>

[rsc, 2010-03-19 22:29:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=f320eb768a3e ***

math: add Gamma function

R=rsc
CC=golang-dev
http://codereview.appspot.com/649041

Committer: Russ Cox <rsc@golang.org>