Issue 6490102: code review 6490102: C: add Francesc Campoy (Google CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6490102: code review 6490102: C: add Francesc Campoy (Google CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by adg

Modified:
12 years, 8 months ago

Reviewers:
fss

CC:
golang-dev, dsymonds, campoy

Visibility:
Public.

Description

C: add Francesc Campoy (Google CLA)

Patch Set 1 #

Patch Set 2 : diff -r 50457a54c26c https://go.googlecode.com/hg #

Patch Set 3 : diff -r 54654f95a754 https://go.googlecode.com/hg #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 8 months ago (2012-09-11 06:46:15 UTC) #1

adg

Yeah already caught it. I blame Francisco Souza! PTAL On 11 September 2012 16:47, David ...

12 years, 8 months ago (2012-09-11 06:48:56 UTC) #3

dsymonds

LGTM but check with Francesc that this is how he wants his name rendered.

12 years, 8 months ago (2012-09-11 06:50:11 UTC) #4

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=3796fdf0d0b8 *** C: add Francesc Campoy (Google CLA) R=golang-dev, dsymonds, campoy CC=golang-dev ...

12 years, 8 months ago (2012-09-11 07:15:27 UTC) #6

fss

12 years, 8 months ago (2012-09-11 20:18:34 UTC) #7

On Tue, Sep 11, 2012 at 3:48 AM, Andrew Gerrand <adg@golang.org> wrote:
> Yeah already caught it. I blame Francisco Souza!

don't blame me :-P


-- 
Francisco Souza

Expand All Messages | Collapse All Messages