code review 6489072: lib9/dial: fix addrlen in connect() and bind()

lib9/dial: fix addrlen in connect() and bind()

On some systems, the third argument of connect() and bind()
is expected to be the length of the address family instead
of the length of the sockaddr structure.

[0intro, 2012-09-03 18:47:27]

Hello rsc,

I'd like you to review this change to
https://code.google.com/p/plan9port/

[rsc, 2012-09-04 22:45:06]

LGTM

What great timing. listen1 still doesn't work on my Mac, though. Now I get
listen1: announce tcp!localhost!9001: Can't assign requested address

[rsc, 2012-09-04 22:45:26]

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=3f6cb195743a
***

lib9/dial: fix addrlen in connect() and bind()

On some systems, the third argument of connect() and bind()
is expected to be the length of the address family instead
of the length of the sockaddr structure.

R=rsc
http://codereview.appspot.com/6489072

Committer: Russ Cox <rsc@swtch.com>

[0intro, 2012-09-05 05:54:37]

> What great timing. listen1 still doesn't work on my Mac, though. Now
> I get listen1: announce tcp!localhost!9001: Can't assign requested
> address

I'm so sorry.
I'll install a FreeBSD machine to investigate on this issue.

-- 
David du Colombier

[0intro, 2012-09-05 06:11:48]

> What great timing. listen1 still doesn't work on my Mac, though. Now
> I get listen1: announce tcp!localhost!9001: Can't assign requested
> address

Could you give me the result of "grep localhost /etc/hosts"
and "ifconfig lo" on your machine?

-- 
David du Colombier

[0intro, 2012-09-06 20:36:37]

I just did some tests on FreeBSD 9.0 and I haven't
encountered this problem. I will investigate further.

[rsc, 2012-09-11 02:18:44]

Just for the review log I believe this is now fixed.