Issue 6489065: code review 6489065: runtime/pprof: emit end-of-log marker at end of CPU profile.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6489065: code review 6489065: runtime/pprof: emit end-of-log marker at end of CPU profile. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by adonovan

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime/pprof: emit end-of-log marker at end of CPU profile.

Patch Set 2 : diff -r 008d345d81e0 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Patch Set 6 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Patch Set 7 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Patch Set 8 : diff -r 29990fa0951c https://code.google.com/p/go/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	src/pkg/runtime/cpuprof.c	View	1 2	4 chunks	+14 lines, -0 lines	0 comments	Download
	M	src/pkg/runtime/pprof/pprof_test.go	View	1 2	1 chunk	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 8 months ago (2012-09-01 01:16:15 UTC) #1

rsc

LGTM http://codereview.appspot.com/6489065/diff/2001/src/pkg/runtime/cpuprof.c File src/pkg/runtime/cpuprof.c (right): http://codereview.appspot.com/6489065/diff/2001/src/pkg/runtime/cpuprof.c#newcode417 src/pkg/runtime/cpuprof.c:417: if (!p->eod_sent) { s/if (/if(/

12 years, 8 months ago (2012-09-01 13:46:36 UTC) #2

adonovan

12 years, 8 months ago (2012-09-04 18:34:09 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=92e962e13197 ***

runtime/pprof: emit end-of-log marker at end of CPU profile.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6489065

Expand All Messages | Collapse All Messages