code review 6488110: strings: more thorough Replacer tests.

strings: more thorough Replacer tests.

This verifies existing behavior. Some replacements are arguably wrong
(these are marked with TODO) but changing behavior is left for a
follow-up CL.

Also fix that BenchmarkGenericMatch wasn't actually matching anything.

[nigeltao, 2012-09-11 03:12:35]

Hello rsc@golang.org (cc: bradfitz@golang.org, eric.d.eisner@gmail.com,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-09-11 03:21:22]

LGTM

http://codereview.appspot.com/6488110/diff/4001/src/pkg/strings/replace_test.go
File src/pkg/strings/replace_test.go (right):

http://codereview.appspot.com/6488110/diff/4001/src/pkg/strings/replace_test....
src/pkg/strings/replace_test.go:74: "i", "i",
Please add 
"xx", "xx",
"x", "X",

and a test that "xxxxx" -> "xxxxX".

[rsc, 2012-09-11 03:23:13]

Oh, and the TODOs involving "" are definitely bugs to be fixed.

[Eric Roshan Eisner, 2012-09-11 03:28:57]

On 2012/09/11 03:12:35, nigeltao wrote:
> Hello mailto:rsc@golang.org (cc: mailto:bradfitz@golang.org,
mailto:eric.d.eisner@gmail.com,
> mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

LGTM. I agree with the placement of all the TODOs, and think they should all be
fixed. While you're moving around all the test tables, maybe you could rearrange
them to have the Replacer definition come right before its testcases, so I don't
have to keep scrolling up and down to check for correctness?

[nigeltao, 2012-09-11 04:37:37]

On 11 September 2012 13:28,  <eric.d.eisner@gmail.com> wrote:
> LGTM. I agree with the placement of all the TODOs, and think they should
> all be fixed. While you're moving around all the test tables, maybe you
> could rearrange them to have the Replacer definition come right before
> its testcases, so I don't have to keep scrolling up and down to check
> for correctness?

Done. Submitting...

[nigeltao, 2012-09-11 04:40:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=46a4f787e8b7 ***

strings: more thorough Replacer tests.

This verifies existing behavior. Some replacements are arguably wrong
(these are marked with TODO) but changing behavior is left for a
follow-up CL.

Also fix that BenchmarkGenericMatch wasn't actually matching anything.

R=rsc, eric.d.eisner
CC=bradfitz, golang-dev
http://codereview.appspot.com/6488110