Issue 6488073: code review 6488073: run.bat: do not run misc\cgo\stdio test on windows (fix...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6488073: code review 6488073: run.bat: do not run misc\cgo\stdio test on windows (fix... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by brainman

Modified:
12 years, 11 months ago

Reviewers:
minux1

CC:
golang-dev

Visibility:
Public.

run.bat: do not run misc\cgo\stdio test on windows (fix build) It is enabled by mistake and should be part of CL 5847068 instead.

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/run.bat	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 4

brainman

Hello golang-dev@googlegroups.com (cc: minux.ma@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-09-03 00:27:48 UTC) #1

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=65b74c8c37f6 *** run.bat: do not run misc\cgo\stdio test on windows (fix build) ...

12 years, 11 months ago (2012-09-03 00:34:05 UTC) #2

minux1

LGTM. i somehow put these two CLs in the same work tree, and i forgot ...

12 years, 11 months ago (2012-09-03 16:30:18 UTC) #3

brainman

12 years, 11 months ago (2012-09-03 23:37:51 UTC) #4

On 2012/09/03 16:30:18, minux wrote:
> 
> ... sorry for the trouble.

No harm done.

Alex