code review 6488069: cmd/go: be clear that import loops are bad

cmd/go: be clear that import loops are bad

There was mail on golang-nuts a few weeks ago
from someone who understood the message perfectly
and knew he had a cyclic dependency but assumed
that Go, like Python or Java, was supposed to handle it.

[rsc, 2012-08-31 22:11:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-08-31 22:16:21]

LGTM
 On Aug 31, 2012 12:11 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: be clear that import loops are bad
>
> There was mail on golang-nuts a few weeks ago
> from someone who understood the message perfectly
> and knew he had a cyclic dependency but assumed
> that Go, like Python or Java, was supposed to handle it.
>
> Please review this at
http://codereview.appspot.com/**6488069/<http://codereview.appspot.com/6488069/>
>
> Affected files:
>   M src/cmd/go/pkg.go
>
>
> Index: src/cmd/go/pkg.go
> ==============================**==============================**=======
> --- a/src/cmd/go/pkg.go
> +++ b/src/cmd/go/pkg.go
> @@ -250,7 +250,7 @@
>                 if p.Error == nil {
>                         p.Error = &PackageError{
>                                 ImportStack: stk.copy(),
> -                               Err:         "import loop",
> +                               Err:         "import cycle not allowed",
>                         }
>                 }
>                 p.Incomplete = true
>
>
>

[dave_cheney.net, 2012-08-31 22:25:00]

LGTM.

http://codereview.appspot.com/6488069/diff/4001/src/cmd/go/pkg.go
File src/cmd/go/pkg.go (right):

http://codereview.appspot.com/6488069/diff/4001/src/cmd/go/pkg.go#newcode253
src/cmd/go/pkg.go:253: Err:         "import cycle not allowed",
nit: maybe "cyclical import not allowed"

[rsc, 2012-09-01 13:41:40]

> src/cmd/go/pkg.go:253: Err:         "import cycle not allowed",
> nit: maybe "cyclical import not allowed"

i don't know, the current text seems more direct.

[dave_cheney.net, 2012-09-01 13:42:59]

Sure thing, LGTM.

On Sat, Sep 1, 2012 at 11:41 PM, Russ Cox <rsc@golang.org> wrote:
>> src/cmd/go/pkg.go:253: Err:         "import cycle not allowed",
>> nit: maybe "cyclical import not allowed"
>
> i don't know, the current text seems more direct.

[rsc, 2012-09-01 14:35:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=f697709b5082 ***

cmd/go: be clear that import loops are bad

There was mail on golang-nuts a few weeks ago
from someone who understood the message perfectly
and knew he had a cyclic dependency but assumed
that Go, like Python or Java, was supposed to handle it.

R=golang-dev, bradfitz, dave
CC=golang-dev
http://codereview.appspot.com/6488069