Issue 6479052: code review 6479052: src: Add support for 64-bit version of Plan 9

Issue 6479052: code review 6479052: src: Add support for 64-bit version of Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by akumar

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, rminnich, npe, rsc, minux1, npe1, akskuma_sandia.gov, jfflore_sandia.gov

Visibility:
Public.

Description

src: Add support for 64-bit version of Plan 9 This set of changes extends the Plan 9 support to include the AMD64 architecture and should work on all versions of Plan 9.

Patch Set 2 : diff -r 93b44db58f94 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 93b44db58f94 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 93b44db58f94 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 9e610a78455c https://code.google.com/p/go #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+761 lines, -7 lines)			Patch
A	include/plan9/amd64/u.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/cmd/6l/pass.c	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/asm_amd64.s	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/defs_plan9_386.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/runtime/defs_plan9_amd64.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/mem_plan9.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/os_plan9.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	src/pkg/runtime/rt0_plan9_amd64.s	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/signal_plan9_amd64.c	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/sys_plan9_amd64.s	View	1	1 chunk	+124 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/asm_plan9_amd64.s	View	1 2 3 4	1 chunk	+166 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9_386.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/syscall_plan9_amd64.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/zerrors_plan9_amd64.go	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/zsyscall_plan9_amd64.go	View	1	1 chunk	+239 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/zsysnum_plan9_amd64.go	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	src/pkg/syscall/ztypes_plan9_amd64.go	View	1	1 chunk	+75 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

akumar

Hello golang-dev@googlegroups.com, rminnich@gmail.com, noah.evans@gmail.com, rsc@golang.org (cc: akskuma@sandia.gov, golang-dev@googlegroups.com, jfflore@sandia.gov, noah.evans@gmail.com, npe@plan9.bell-labs.com), I'd like you to ...

12 years, 10 months ago (2012-08-25 01:02:56 UTC) #1

rminnich

I've run both the Go tool and gofmt on 64-bit Plan 9 and they both ...

12 years, 10 months ago (2012-08-25 16:07:47 UTC) #2

minux1

http://codereview.appspot.com/6479052/diff/7001/src/pkg/syscall/asm_plan9_amd64.s File src/pkg/syscall/asm_plan9_amd64.s (right): http://codereview.appspot.com/6479052/diff/7001/src/pkg/syscall/asm_plan9_amd64.s#newcode127 src/pkg/syscall/asm_plan9_amd64.s:127: #define SYS_SEEK 39 /* from zsysnum_nxm_amd64.go */ zsysnum_nxm_amd64.go? maybe ...

12 years, 10 months ago (2012-08-25 17:18:59 UTC) #3

akumar

PTAL. http://codereview.appspot.com/6479052/diff/7001/src/pkg/syscall/asm_plan9_amd64.s File src/pkg/syscall/asm_plan9_amd64.s (right): http://codereview.appspot.com/6479052/diff/7001/src/pkg/syscall/asm_plan9_amd64.s#newcode127 src/pkg/syscall/asm_plan9_amd64.s:127: #define SYS_SEEK 39 /* from zsysnum_nxm_amd64.go */ On ...

12 years, 10 months ago (2012-08-25 19:05:57 UTC) #4

npe1

LGTM On 2012/08/25 19:05:57, akumar wrote: > PTAL. > > http://codereview.appspot.com/6479052/diff/7001/src/pkg/syscall/asm_plan9_amd64.s > File src/pkg/syscall/asm_plan9_amd64.s (right): ...

12 years, 10 months ago (2012-08-28 09:19:04 UTC) #5

rsc

12 years, 10 months ago (2012-08-31 17:21:19 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=0bd4ca4547b5 ***

src: Add support for 64-bit version of Plan 9

This set of changes extends the Plan 9 support
to include the AMD64 architecture and should
work on all versions of Plan 9.

R=golang-dev, rminnich, noah.evans, rsc, minux.ma, npe
CC=akskuma, golang-dev, jfflore, noah.evans
http://codereview.appspot.com/6479052

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages