Issue 6476043: code review 6476043: A+C: add Joakim Sernbrant

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6476043: code review 6476043: A+C: add Joakim Sernbrant (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by adg

Modified:
13 years, 3 months ago

Reviewers:
iant2

CC:
golang-dev, nigeltao

Visibility:
Public.

Description

A+C: add Joakim Sernbrant

Patch Set 1 #

Patch Set 2 : diff -r 1e84edee3397 https://go.googlecode.com/hg #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	CONTRIBUTORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 3 months ago (2012-08-22 00:59:10 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=dd0a97869e4d *** A+C: add Joakim Sernbrant R=golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/6476043

13 years, 3 months ago (2012-08-22 01:03:29 UTC) #3

iant2

13 years, 3 months ago (2012-08-22 01:03:33 UTC) #4

LGTM

CL description should say "(individual CLA)".

Ian

On Tue, Aug 21, 2012 at 5:59 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> A+C: add Joakim Sernbrant
>
> Please review this at http://codereview.appspot.com/6476043/
>
> Affected files:
>   M AUTHORS
>   M CONTRIBUTORS
>
>
> Index: AUTHORS
> ===================================================================
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -117,6 +117,7 @@
>  Jeff R. Allen <jra@nella.org>
>  Jeremy Jackins <jeremyjackins@gmail.com>
>  Jim McGrath <jimmc2@gmail.com>
> +Joakim Sernbrant <serbaut@gmail.com>
>  Joe Poirier <jdpoirier@gmail.com>
>  John Asmuth <jasmuth@gmail.com>
>  Jonathan Gold <jgold.bg@gmail.com>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -172,6 +172,7 @@
>  Jeff R. Allen <jra@nella.org> <jeff.allen@gmail.com>
>  Jeremy Jackins <jeremyjackins@gmail.com>
>  Jim McGrath <jimmc2@gmail.com>
> +Joakim Sernbrant <serbaut@gmail.com>
>  Joe Poirier <jdpoirier@gmail.com>
>  Joel Sing <jsing@google.com>
>  Johan Euphrosine <proppy@google.com>
>
>

Expand All Messages | Collapse All Messages