Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(866)

Issue 6475065: Adds octavation-eight-interface to the Beam_collision_engraver (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by MikeSol
Modified:
11 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds octavation-eight-interface to the Beam_collision_engraver

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M lily/beam-collision-engraver.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +8 lines, -0 lines 2 comments Download
M scm/define-grobs.scm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Graham Percival
LGTM
11 years, 8 months ago (2012-08-27 08:53:59 UTC) #1
dak
http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm#newcode223 scm/define-grob-interfaces.scm:223: annotation." What about \clef "bass_8" or \clef "treble_15" ?
11 years, 8 months ago (2012-08-29 14:13:47 UTC) #2
mike7
On 29 août 2012, at 16:13, dak@gnu.org wrote: > > http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm > File scm/define-grob-interfaces.scm (right): ...
11 years, 8 months ago (2012-08-29 15:48:36 UTC) #3
dak
On 2012/08/29 15:48:36, mike7 wrote: > On 29 août 2012, at 16:13, mailto:dak@gnu.org wrote: > ...
11 years, 8 months ago (2012-08-29 16:17:52 UTC) #4
janek
11 years, 8 months ago (2012-08-30 08:37:12 UTC) #5
http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (right):

http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm#n...
scm/define-grob-interfaces.scm:223: annotation."
I don't quite understand what this description means.  Reword please?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b