code review 6472055: net/http: send an explicit zero Content-Length when Han...

net/http: send an explicit zero Content-Length when Handler never Writes

Fixes issue 4004

[bradfitz, 2012-08-26 06:39:08]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-08-26 13:28:32]

http://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

http://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#ne...
src/pkg/net/http/server.go:516: // response header, set it explicitly to zero.
This helps HTTP/1.0
s/it/the length/

http://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#ne...
src/pkg/net/http/server.go:517: // clients keep their keep-alive connections
alive, and is just as an
"clients keep their connections alive"? it reads oddly, but it maybe what you
mean

http://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#ne...
src/pkg/net/http/server.go:518: // HTTP/1.1 chunked response closing immediately
with a zero EOF chunk.
"zero-length"?

i find this comment unclear.

[bradfitz, 2012-08-26 16:24:45]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-08-26 16:25:03]

https://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go
File src/pkg/net/http/server.go (right):

https://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:516: // response header, set it explicitly to zero.
This helps HTTP/1.0
On 2012/08/26 13:28:32, r wrote:
> s/it/the length/

Done.

https://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:517: // clients keep their keep-alive connections
alive, and is just as an
On 2012/08/26 13:28:32, r wrote:
> "clients keep their connections alive"? it reads oddly, but it maybe what you
> mean

Yeah, this is what I meant.  Now that you point it out, it does read oddly, but
changing it to not include "keep-alive" would be dropping the main point. 
HTTP/1.0 TCP connections close by default after a response, unless both 1) the
client requests "Connection: keep-alive", and 2) the server's response includes
an explicit Content-Length.

I put "keep-alive" in quotes, though, to make it obvious that it's a special
term and not just an adjective.

https://codereview.appspot.com/6472055/diff/5001/src/pkg/net/http/server.go#n...
src/pkg/net/http/server.go:518: // HTTP/1.1 chunked response closing immediately
with a zero EOF chunk.
On 2012/08/26 13:28:32, r wrote:
> "zero-length"?
> 
> i find this comment unclear.

Added the missing word and reworded a bit.

[r, 2012-08-26 18:10:20]

LGTM
much clearer

[bradfitz, 2012-08-26 18:18:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=c552fb2b6a6c ***

net/http: send an explicit zero Content-Length when Handler never Writes

Fixes issue 4004

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6472055