Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1465)

Issue 6465044: Modified font information tool based on requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by yehh
Modified:
11 years, 8 months ago
Reviewers:
CraigC, stuartg
CC:
bstell1
Base URL:
http://sfntly.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modified font information tool based on requests. - Added glyph ID for each character to listing of characters - Removed redundant trailing spaces for left-aligned columns at the end of each row - Added function to produce properly-formatted code point strings (U+hhhh or U+hhhhhh)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merged functionality of prettyPrint and prettyString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -44 lines) Patch
M java/src/com/google/typography/font/tools/fontinfo/DataDisplayTable.java View 1 3 chunks +21 lines, -32 lines 0 comments Download
M java/src/com/google/typography/font/tools/fontinfo/FontInfo.java View 4 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 5
yehh
Modified font information tool based on requests. - Added glyph ID for each character to ...
11 years, 8 months ago (2012-08-13 20:56:30 UTC) #1
stuartg
http://codereview.appspot.com/6465044/diff/1/java/src/com/google/typography/font/tools/fontinfo/DataDisplayTable.java File java/src/com/google/typography/font/tools/fontinfo/DataDisplayTable.java (right): http://codereview.appspot.com/6465044/diff/1/java/src/com/google/typography/font/tools/fontinfo/DataDisplayTable.java#newcode161 java/src/com/google/typography/font/tools/fontinfo/DataDisplayTable.java:161: public String prettyString() { prettyPrint and prettyString need to ...
11 years, 8 months ago (2012-08-13 21:27:11 UTC) #2
yehh
Merged functionality of prettyPrint and prettyString; uploaded new patch set
11 years, 8 months ago (2012-08-13 21:29:34 UTC) #3
stuartg
LGTM
11 years, 8 months ago (2012-08-13 21:32:47 UTC) #4
CraigC
11 years, 8 months ago (2012-08-13 22:10:58 UTC) #5
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b