Issue 6464066: Allow escaping algorithm to be specified in GenericUrl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6464066: Allow escaping algorithm to be specified in GenericUrl

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rmistry

Modified:
11 years, 4 months ago

Reviewers:
yanivi

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Description

Created to fix http://code.google.com/p/google-http-java-client/issues/detail?id=26 : Allow GenericUrl.build() to be overridden.

Patch Set 1 #

Patch Set 2 : Minor fix #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -15 lines)			Patch
A	google-http-client/src/main/java/com/google/api/client/http/DefaultGenericUrlEscaper.java	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java	View	1	14 chunks	+64 lines, -14 lines	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/http/GenericUrlEscaper.java	View		1 chunk	+37 lines, -0 lines	2 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/GenericUrlTest.java	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmistry

On 2012/08/20 13:11:34, yanivi wrote: > I vote for delaying this to 1.12. Done.

11 years, 9 months ago (2012-08-20 13:18:55 UTC) #3

yanivi

11 years, 4 months ago (2013-01-22 16:20:42 UTC) #4

I think we should defer this to 2.1.

https://codereview.appspot.com/6464066/diff/2001/google-http-client/src/main/...
File
google-http-client/src/main/java/com/google/api/client/http/GenericUrlEscaper.java
(right):

https://codereview.appspot.com/6464066/diff/2001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/GenericUrlEscaper.java:24:
public interface GenericUrlEscaper {
[optional] what do you think of making this interface nested inside GenericUrl
since it is only meaningful in that context

https://codereview.appspot.com/6464066/diff/2001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/GenericUrlEscaper.java:36:
public String decodeUri(String uri);
I don't think it makes sense to provide a way to decode a URI since our decoding
algorithm should be correct.  I think it is only the encoding that we want to
allow to be customized.

Expand All Messages | Collapse All Messages