Issue 6462051: Inline labels should be inline.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6462051: Inline labels should be inline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by xiaq

Modified:
12 years, 4 months ago

Reviewers:
jaiditya, thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Patch Set 2 : modified stylus source and regenerated css #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -18 lines)			Patch
M	MoinMoin/templates/forms.html	View	1	2 chunks	+8 lines, -6 lines	1 comment	Download
M	MoinMoin/themes/foobar/static/css/common.css	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
M	MoinMoin/themes/foobar/static/css/stylus/main.styl	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	MoinMoin/themes/modernized/static/css/common.css	View	1	3 chunks	+6 lines, -5 lines	1 comment	Download
M	MoinMoin/themes/modernized/static/css/stylus/main.styl	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ThomasJWaldmann

http://codereview.appspot.com/6462051/diff/1/MoinMoin/themes/modernized/static/css/common.css File MoinMoin/themes/modernized/static/css/common.css (right): http://codereview.appspot.com/6462051/diff/1/MoinMoin/themes/modernized/static/css/common.css#newcode520 MoinMoin/themes/modernized/static/css/common.css:520: .moin-inline-label{display:inline} iirc, modernized is now also based on stylus ...

12 years, 4 months ago (2012-08-13 06:33:08 UTC) #1

jaiditya

Yeah, I saw it, and its not enough to produce the intended output, I have ...

12 years, 4 months ago (2012-08-17 22:29:24 UTC) #3

Reimar Bauer

12 years, 4 months ago (2012-08-18 06:19:27 UTC) #4

some questions

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/templates/forms.html
File MoinMoin/templates/forms.html (right):

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/templates/forms.html...
MoinMoin/templates/forms.html:28: <dt class="moin-textcha">
is moin-textcha defined?

Or ToDo?

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/themes/modernized/st...
File MoinMoin/themes/modernized/static/css/common.css (right):

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/themes/modernized/st...
MoinMoin/themes/modernized/static/css/common.css:184:
html{color:#000;font-family:Helvetica,Arial,sans-serif}
Why Helvetica,Arial

Is that added because stylus executed on linux?

Expand All Messages | Collapse All Messages