Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 6462051: Inline labels should be inline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by xiaq
Modified:
11 years, 7 months ago
Reviewers:
jaiditya, thomas.j.waldmann, Reimar Bauer
Visibility:
Public.

Description

Inline labels should be inline.

Patch Set 1 #

Total comments: 1

Patch Set 2 : modified stylus source and regenerated css #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M MoinMoin/templates/forms.html View 1 2 chunks +8 lines, -6 lines 1 comment Download
M MoinMoin/themes/foobar/static/css/common.css View 1 3 chunks +8 lines, -7 lines 0 comments Download
M MoinMoin/themes/foobar/static/css/stylus/main.styl View 1 1 chunk +3 lines, -0 lines 0 comments Download
M MoinMoin/themes/modernized/static/css/common.css View 1 3 chunks +6 lines, -5 lines 1 comment Download
M MoinMoin/themes/modernized/static/css/stylus/main.styl View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ThomasJWaldmann
http://codereview.appspot.com/6462051/diff/1/MoinMoin/themes/modernized/static/css/common.css File MoinMoin/themes/modernized/static/css/common.css (right): http://codereview.appspot.com/6462051/diff/1/MoinMoin/themes/modernized/static/css/common.css#newcode520 MoinMoin/themes/modernized/static/css/common.css:520: .moin-inline-label{display:inline} iirc, modernized is now also based on stylus ...
11 years, 7 months ago (2012-08-13 06:33:08 UTC) #1
ThomasJWaldmann
Looks ok. I assume you tested it... :)
11 years, 7 months ago (2012-08-17 17:48:55 UTC) #2
jaiditya
Yeah, I saw it, and its not enough to produce the intended output, I have ...
11 years, 7 months ago (2012-08-17 22:29:24 UTC) #3
Reimar Bauer
11 years, 7 months ago (2012-08-18 06:19:27 UTC) #4
some questions

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/templates/forms.html
File MoinMoin/templates/forms.html (right):

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/templates/forms.html...
MoinMoin/templates/forms.html:28: <dt class="moin-textcha">
is moin-textcha defined?

Or ToDo?

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/themes/modernized/st...
File MoinMoin/themes/modernized/static/css/common.css (right):

http://codereview.appspot.com/6462051/diff/7002/MoinMoin/themes/modernized/st...
MoinMoin/themes/modernized/static/css/common.css:184:
html{color:#000;font-family:Helvetica,Arial,sans-serif}
Why Helvetica,Arial

Is that added because stylus executed on linux?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b