YCC Distance Matte Node implementation

The Distance Node in 2.49 has a different calculation for RGB and YCC. While RGB calculate the distance in 3d between R,G and B, the YCC only takes Cb and Cr into consideration.

See if this implementation is ok.
Basically I:
- renamed COM_DistanceMatteOperation into COM_DistanceRGBMatteOperation
- turned the private properties into private
- isolated the distance calculation function into a new function
- inherited this file for the COM_DistanceYCCMatteOperation
- overriding the function calculateDistance.

Thanks,
Dalai

[jbkkavt, 2012-08-15 18:46:00]

have some issues to view the patch (the review site does not work) I think you
did an svn mv on two files.

Not sure about the functionality (I am just not the subject expert), perhaps
this could be better asked to bf-committers.

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/...
File source/blender/compositor/nodes/COM_DistanceMatteNode.cpp (right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/...
source/blender/compositor/nodes/COM_DistanceMatteNode.cpp:64: addLink(graph,
operationYCCMatte->getOutputSocket(), operation->getInputSocket(1));
operationYCCImage, operationYCCMatte are created but not added to the graph
[graph->addOperation]. This will defect the execution (no init/deinit will be
executed for these operations

[dfelinto, 2012-08-15 20:20:48]

Hi Jeroen,

Regarding the patch (attached since the codereview didn't work) this
brings back 2.49 original functionality.
aka it's important if we really want to go 100% backward compatible.
Though it's possible people don't use that node.

I will try to find time to write on bf-committers. Just been very busy
lately, but wanted that in (or out) before 2.64 is out.

Thanks,
Dalai

2012/8/15  <jbkkavt@gmail.com>:
> have some issues to view the patch (the review site does not work) I
> think you did an svn mv on two files.
>
> Not sure about the functionality (I am just not the subject expert),
> perhaps this could be better asked to bf-committers.
>
>
>
>
http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/...
> File source/blender/compositor/nodes/COM_DistanceMatteNode.cpp (right):
>
>
http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/nodes/...
> source/blender/compositor/nodes/COM_DistanceMatteNode.cpp:64:
> addLink(graph, operationYCCMatte->getOutputSocket(),
> operation->getInputSocket(1));
> operationYCCImage, operationYCCMatte are created but not added to the
> graph [graph->addOperation]. This will defect the execution (no
> init/deinit will be executed for these operations
>
> http://codereview.appspot.com/6462050/

[jbkkavt, 2012-08-16 12:42:32]

Ok, just reviewed the last part of it. Don't think we can commit without
discussing this as this patch solves a bug and does not change functionality.
Sorry for the misunderstanding... 

It seems that the calculateDistance method is not defined protected and virtual.

With these adjustments it is ok to commit.
 * make calculateDistance protected virtual
 * remove execute pixel from subclass (when it is exactly the same)
 * add conversion operations to executionsystem

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
File source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
source/blender/compositor/operations/COM_DistanceRGBMatteOperation.h:37: +	float
calculateDistance(float key[4], float image[4]);
Define this function protected virtual, 
and only implement the execute pixel in the DistanceRGB matte, when it is exact
the same.

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
File source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.cpp:37: {
Remove this method as it is the same as the base class

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
File source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h
(right):

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h:33:
private:
make this protected to use the definition in the base class

http://codereview.appspot.com/6462050/diff/1/source/blender/compositor/operat...
source/blender/compositor/operations/COM_DistanceYCCMatteOperation.h:46: 
Remove the execute pixel as it is the same in the base class