Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2243)

Issue 6461085: Properties to control placement of accidentals in KeySignatures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Keith
Modified:
11 years, 8 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Properties to control placement of accidentals in KeySignatures

Patch Set 1 #

Patch Set 2 : had conventions swapped, flats vs sharps #

Total comments: 1

Patch Set 3 : generalize, and document #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -57 lines) Patch
M Documentation/notation/pitches.itely View 1 2 2 chunks +31 lines, -1 line 0 comments Download
M input/regression/key-clefs.ly View 1 2 2 chunks +15 lines, -3 lines 0 comments Download
M lily/key-signature-interface.cc View 1 2 4 chunks +18 lines, -12 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 1 chunk +23 lines, -41 lines 0 comments Download

Messages

Total messages: 4
dak
Will the added generality be enough? Should we not try to come up with some ...
11 years, 8 months ago (2012-08-16 08:39:14 UTC) #1
Keith
On Thu, 16 Aug 2012 01:39:15 -0700, <dak@gnu.org> wrote: > Will the added generality be ...
11 years, 8 months ago (2012-08-16 17:32:49 UTC) #2
dak
http://codereview.appspot.com/6461085/diff/2001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6461085/diff/2001/scm/define-grob-properties.scm#newcode481 scm/define-grob-properties.scm:481: for the clef, such as @code{#(2 3 4 2 ...
11 years, 8 months ago (2012-08-16 18:09:51 UTC) #3
Keith
11 years, 8 months ago (2012-08-17 04:07:18 UTC) #4
On Thu, 16 Aug 2012 11:09:51 -0700, <dak@gnu.org> wrote:

>
http://codereview.appspot.com/6461085/diff/2001/scm/define-grob-properties.sc...
> >  indexed by the staff-position of the first C above centerline
> This kind of indexing looks like it would only work for reasonably
> standard staffs where this staff-position is constrained to 0..6.
>

I sloppily wrote 'centerline' to mean staff-position zero.  I could be more
accurate if I said "the staff-position of the first C with a non-negative staff
position" but hopefully I'll think of something easier to understand.

> http://codereview.appspot.com/6461085/

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b